David Jacot
David Jacot
> i see `kafka.api.SaslSslConsumerTest.testCoordinatorFailover(String, String).quorum=kraft+kip848.groupProtocol=consumer` failing. is this unrelated? I checked but I could not link it to my changes. It seems to be a flaky test.
@chia7712 I will. I’d like to merge https://github.com/apache/kafka/pull/17057 before this one.
@chia7712 @jolshan The PR is ready for another round.
@chia7712 @jolshan I addressed the last comments.
Ah, I just noticed that they are failed tests that seem related. Could you please take a look into those?
@lianetm @frankvicky I wonder if we should also do the same on timeouts. Did we in the old implementation?
@chia7712 I haven't followed all the conversation in this PR but I have an opinion about your last statement. > Do we need to align all behaviors between the classic...
I like Jason's suggestion. I think that we could take this idea further and also have the background thread send a CloseCompleted event to the foreground thread when it is...
> @dajac writes: > > > I suppose that the test passes with new MockTime(1L) because the new time is not used by the client. The client must be created...
@chia7712 Could you please take a second look?