kafka icon indicating copy to clipboard operation
kafka copied to clipboard

KAFKA-17050: Revert `group.version`

Open dajac opened this issue 1 year ago • 5 comments

This patch partially reverts group.version in trunk. I kept the GroupVersion class but removed it from Features so it is not advertised. I also kept all the changes in the test framework. I removed the logic to require group.version=1 to enable the new consumer rebalance protocol. The new protocol is enabled based on the static configuration.

For the context, I prefer to revert it in trunk now so we don't forget to revert it in the 3.9 release. I will bring it back for the 4.0 release.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

dajac avatar Jun 28 '24 08:06 dajac

@chia7712 Could you please take a second look?

dajac avatar Jul 01 '24 06:07 dajac

@dajac could you please fix the build error

chia7712 avatar Jul 01 '24 10:07 chia7712

@chia7712 Done. Sorry for that.

dajac avatar Jul 01 '24 12:07 dajac

I guess testConsumerGroupDescribeIsInaccessibleWhenDisabledByGroupVersion needs to be reverted also.

https://github.com/apache/kafka/blob/trunk/core/src/test/scala/unit/kafka/server/ConsumerGroupDescribeRequestsTest.scala#L75

chia7712 avatar Jul 01 '24 14:07 chia7712

@chia7712 Right. I just removed it.

dajac avatar Jul 01 '24 15:07 dajac

There are a few failed tests that I need to fix…

dajac avatar Jul 01 '24 18:07 dajac