David Jacot comments

Results 59 comments of


                                            David Jacot

KAFKA-14511: extend AlterIncrementalConfigs API to support group config

I spoke too quickly. @DL1231 There are related failed tests. For instance: * testInvalidProps() – org.apache.kafka.coordinator.group.GroupConfigTest Could you please check?

KAFKA-14511: extend AlterIncrementalConfigs API to support group config

@DL1231 The last build failed with compilation errors. Could you please check? I would also advice to not rebase and force-push from now on. It will be easier for me...

POC: run group coordinator state machine on request handler pool

Thanks for the PR. I believe that isolating the workload from the produce/fetch workload (running in the api handlers) is actually a good thing but we would need to measure...

POC: run group coordinator state machine on request handler pool

I am not sure to fully understand your point. You cannot change the granularity without changing how events are created in the first place. Moreover, CoordinatorEventProcessor is not right to...

MINOR: KIP-848 Uniform Assignor Bugs

Thanks @rreddy-22! Could you please describe the bug(s) in the description? Do we need to add new tests for them?

MINOR: KIP-848 Uniform Assignor Bugs

@rreddy-22 Understood. In this case, it would be better to mark it as draft.

MINOR: KIP-848 Uniform Assignor Bugs

@rreddy-22 Do we still need this one?

MINOR: KIP-848 Uniform Assignor Bugs

This does not seem necessary any more. Closing it.

KAFKA-17306; Soften the validation when replaying tombstones

@jeffkbkim @frankvicky Thanks for your comments. I have addressed them.

KAFKA-17306; Soften the validation when replaying tombstones

> thanks, left a minor comment. Seems like we have a bit of test failures related to this PR @jeffkbkim Which tests are you referring to? They actually look pretty...