David Jacot comments

Results 59 comments of


                                            David Jacot

MINOR: Expose client information on RequestContext as additional public API beyond request logs (continuation of KIP 511)

@methodmissing We also expose a metric with the number of clients per software name and version. Have you already checked this out?

MINOR: Expose client information on RequestContext as additional public API beyond request logs (continuation of KIP 511)

I'm closing this PR as it needs to be discussed in a KIP anyway. Feel free to reopen it if needed.

KAFKA-14009: update rebalance timeout in memory when consumers use st…

@Stephan14 I will review it next week.

KAFKA-14009: update rebalance timeout in memory when consumers use st…

@Stephan14 Many tests, related to your change, failed in the last build. Could you please take a look? ``` Build / JDK 11 and Scala 2.13 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest

KAFKA-14009: update rebalance timeout in memory when consumers use st…

@Stephan14 Thanks for the patch!

KAFKA-14009: update rebalance timeout in memory when consumers use st…

Merged to trunk and 3.3.

KAFKA-7109: Close fetch sessions on close of consumer

@divijvaidya Sorry again for the long delay. By the way, I was wondering if we should also do this in the AbstractFetcherThread in order to close sessions used by replication...

KAFKA-16249; Improve reconciliation state machine

@jeffkbkim Thanks for your comments. I have addressed them.

KAFKA-16249; Improve reconciliation state machine

@jeffkbkim Thanks for your comments. I have addressed all of them.

KAFKA-16249; Improve reconciliation state machine

> > This is a non-backward compatible change. I think that we should do this change to cleanup the record. As KIP-848 is only in early access in 3.7 and...