David Jacot
David Jacot
@jolshan Thanks for your comments. I addressed them.
@rreddy-22 There are conflicts due to changes made in https://github.com/apache/kafka/commit/88c5543ccfb517ceba8dc56d22576efdf2540e0e. Could you take a look when you get a chance?
In my opinion, we should not merge the client side only after the server side is implemented. The reason is that we need to change the RPC (this is actually...
@cadonna Yes. We could for instance commit the RPC and then work independently on the client and the server. My only concern is that we usually discover issues while working...
@Phuc-Hong-Tran Yep, that's right.
> > @cadonna @lianetm, since we're supporting for both subscribe method using java.util.regex.Pattern and SubscriptionPattern, I think we should throw a illegal heartbeat exeption when user try to use both...
I was wondering whether we should introduce a new error code to signal to the user that the regular expression is invalid. Otherwise, we would have to use the invalid...
Thanks folks. I will review it soon.
I'll be away until 7/29. I will continue reviewing this PR when I come back.
@DL1231 I am back. Thanks for the update. I will review your PR asap.