kafka icon indicating copy to clipboard operation
kafka copied to clipboard
verified publisher icon apache

KAFKA-14511: extend AlterIncrementalConfigs API to support group config

Open DL1231 opened this issue 2 years ago • 10 comments

This PR add resources to store and handle consumer group config. jira

Changes include:

  • Adding GRUOP to resource type
  • Corresponding DYNAMIC consumer group configurations in resources.
  • Changes to support dynamic loading of configuration on changes.
  • Test cases for the changes

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

DL1231 avatar Dec 24 '23 08:12 DL1231

@AndrewJSchofield, I've updated the PR. Please take a look again. Thanks.

DL1231 avatar Jan 10 '24 03:01 DL1231

Thanks @AndrewJSchofield for the feedback, I have addressed comments.

DL1231 avatar Jan 14 '24 03:01 DL1231

@dajac, PTAL, thanks in advance.

DL1231 avatar Jan 17 '24 12:01 DL1231

This PR is being marked as stale since it has not had any activity in 90 days. If you would like to keep this PR alive, please ask a committer for review. If the PR has merge conflicts, please update it with the latest from trunk (or appropriate release branch)

If this PR is no longer valid or desired, please feel free to close it. If no activity occurs in the next 30 days, it will be automatically closed.

github-actions[bot] avatar May 21 '24 03:05 github-actions[bot]

@DL1231 I'm interested in getting group configs working. This PR is quite out of date, in particular because there's been a lot of refactoring of configs in Kafka recently. Would you like to rebase it and get it working again? Alternatively, I'm happy to take the work on instead.

AndrewJSchofield avatar Jun 06 '24 15:06 AndrewJSchofield

@AndrewJSchofield I've resolved the conflict, PTAL, thanks in advance.

DL1231 avatar Jun 15 '24 06:06 DL1231

@DL1231 Yes, I'll give the updated code a detailed review in the next few days. Thanks for rebasing it.

AndrewJSchofield avatar Jun 17 '24 07:06 AndrewJSchofield

@AndrewJSchofield I've updated the PR. Please take a look again. Thanks.

DL1231 avatar Jun 20 '24 02:06 DL1231

Thanks folks. I will review it soon.

dajac avatar Jun 26 '24 15:06 dajac

@dajac I've updated the PR. Please take a look again. Thanks.

DL1231 avatar Jul 01 '24 12:07 DL1231

I'll be away until 7/29. I will continue reviewing this PR when I come back.

dajac avatar Jul 05 '24 09:07 dajac

@dajac Sorry for the delay, I've updated the PR, PTAL when you get a chance.

DL1231 avatar Jul 07 '24 07:07 DL1231

@DL1231 I am back. Thanks for the update. I will review your PR asap.

dajac avatar Jul 30 '24 13:07 dajac

Hi @dajac. Thanks a lot for the review. I have made the required changes in the last commit, PTAL when you get a chance.

DL1231 avatar Aug 08 '24 14:08 DL1231

I spoke too quickly. @DL1231 There are related failed tests. For instance:

  • testInvalidProps() – org.apache.kafka.coordinator.group.GroupConfigTest Could you please check?

dajac avatar Aug 09 '24 11:08 dajac

@DL1231 The last build failed with compilation errors. Could you please check? I would also advice to not rebase and force-push from now on. It will be easier for me to follow the fixes. Otherwise, I have to go through the entire PR.

dajac avatar Aug 09 '24 12:08 dajac