kafka icon indicating copy to clipboard operation
kafka copied to clipboard
verified publisher icon apache

KAFKA-14009: update rebalance timeout in memory when consumers use st…

Open Stephan14 opened this issue 3 years ago • 3 comments

When consumers use static membership protocol and do not happen rebalance, consumers can not update rebalance timeout when users want to reduce rebalance timeout

Summary of testing strategy (including rationale) for the feature or bug fix. Unit and/or integration tests are expected for any behaviour change and system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • [ ] Verify design and implementation
  • [ ] Verify test coverage and CI build status
  • [ ] Verify documentation (including upgrade notes)

Stephan14 avatar Jun 19 '22 08:06 Stephan14

@guozhangwang Can you help review this code?

Stephan14 avatar Jun 24 '22 05:06 Stephan14

@Stephan14 I will review it next week.

dajac avatar Jun 24 '22 16:06 dajac

@Stephan14 Thanks for the patch. Nice catch! I have two high level comments:

  1. Could we add a unit test for this?
  2. Do we have a similar issue with the session timeout?

@dajac

  1. I have added test for this
  2. I update session timeout at the same time

Stephan14 avatar Jun 28 '22 17:06 Stephan14

@dajac I have modify the code.

Stephan14 avatar Oct 16 '22 08:10 Stephan14

@dajac Can you help me review it? Thanks.

Stephan14 avatar Nov 02 '22 13:11 Stephan14

@dajac I have fixed it again and can you help me review it ?

Stephan14 avatar Nov 06 '22 14:11 Stephan14

@dajac I have fix it and can you review it?

Stephan14 avatar Nov 08 '22 15:11 Stephan14

@Stephan14 Many tests, related to your change, failed in the last build. Could you please take a look?

Build / JDK 11 and Scala 2.13 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
<1s
Build / JDK 11 and Scala 2.13 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
4s
Build / JDK 8 and Scala 2.12 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
<1s
Build / JDK 8 and Scala 2.12 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
3s
Build / JDK 17 and Scala 2.13 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
<1s
Build / JDK 17 and Scala 2.13 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest

dajac avatar Nov 09 '22 07:11 dajac

@Stephan14 Many tests, related to your change, failed in the last build. Could you please take a look?

Build / JDK 11 and Scala 2.13 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
<1s
Build / JDK 11 and Scala 2.13 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
4s
Build / JDK 8 and Scala 2.12 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
<1s
Build / JDK 8 and Scala 2.12 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
3s
Build / JDK 17 and Scala 2.13 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest
<1s
Build / JDK 17 and Scala 2.13 / staticMemberRejoinWithUnknownMemberIdAndChangeOfProtocolWhileSelectProtocolUnchangedPersistenceFailure() – kafka.coordinator.group.GroupCoordinatorTest

@dajac I have fixed it.

Stephan14 avatar Nov 13 '22 11:11 Stephan14

@Stephan14 Thanks for the patch!

dajac avatar Nov 24 '22 14:11 dajac

Merged to trunk and 3.3.

dajac avatar Nov 24 '22 14:11 dajac