Chris Yang

Results 81 comments of Chris Yang

Need to wait until https://github.com/flutter/engine/pull/32820 going to stable before we can land this, so that the test can pass on both stable and master

The engine roll commit is: https://github.com/flutter/flutter/commit/dd65b6ba5bef2a9b62714025429feeb405b046cc We can merge when is commit is in stable branch.

@spesholized Friendly ping. Have you gotten a chance to look at Stuart's comment?

@PiotrMitkowski Friendly ping :) Are you planning on continuing this PR?

I will take a look at https://github.com/flutter/plugins/pull/5914

@mitghi Friendly ping. Are you planning to resolve the comments from Stuart?

No need to update version because all the files are test files

Also need to rebase or merge upstream/main and resolve conflicts.

The new tests seem to be failing: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8808283911804283841/+/u/test:_Host_Tests_for_ios_debug_sim__2_/stdout?format=raw