packages icon indicating copy to clipboard operation
packages copied to clipboard

Published 20 hours ago • verified publisher icon flutter

[multiple] Format code

Open cyanglaz opened this issue 2 years ago • 3 comments

Apply new format rules to some dart files.

This fixes the flutter -> plugin roll

Flutter roll included: https://github.com/flutter/packages/pull/2448

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran [the auto-formatter]. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cyanglaz avatar Aug 12 '22 19:08 cyanglaz

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat (don't just cc him here, he won't see it! He's on Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

flutter-dashboard[bot] avatar Aug 12 '22 19:08 flutter-dashboard[bot]

No need to update version because all the files are test files

cyanglaz avatar Aug 12 '22 19:08 cyanglaz

test-exempt: formatting. also, is a test.

Hixie avatar Aug 12 '22 19:08 Hixie

Landing manually; publishabel failure is incorrect due to https://github.com/cirruslabs/cirrus-ci-docs/issues/1054

stuartmorgan avatar Aug 15 '22 18:08 stuartmorgan