plugins icon indicating copy to clipboard operation
plugins copied to clipboard

Published 20 hours ago • verified publisher icon flutter

[image_picker] add requestFullMetadata for iOS (optional permissions) - iOS changes

Open PiotrMitkowski opened this issue 2 years ago • 7 comments

Description

iOS changes for https://github.com/flutter/plugins/pull/4638

Related issues

flutter/flutter#65995

Pre-launch Checklist

  • [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [x] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [x] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [x] I signed the CLA.
  • [x] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [x] I listed at least one issue that this PR fixes in the description above.
  • [x] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [x] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [x] I updated/added relevant documentation (doc comments with ///).
  • [x] I added new tests to check the change I am making, or this PR is test-exempt.
  • [x] All existing and new tests are passing.

PiotrMitkowski avatar May 13 '22 09:05 PiotrMitkowski

@stuartmorgan @cyanglaz I moved iOS specific changes to a separate branch, as suggested.

PiotrMitkowski avatar May 13 '22 09:05 PiotrMitkowski

Friendly bump, looks like the nits were addressed.

jmagman avatar May 31 '22 22:05 jmagman

@PiotrMitkowski Friendly ping :) Are you planning on continuing this PR?

cyanglaz avatar Jun 30 '22 15:06 cyanglaz

@cyanglaz Sure, I got stuck on waiting for review of this one: https://github.com/flutter/plugins/pull/5914, which blocks further work on adding requestFullMetadata flag. I wanted to avoid too much pinging, but I guess it's a good time to post it on Discord :)

PiotrMitkowski avatar Jun 30 '22 18:06 PiotrMitkowski

I will take a look at https://github.com/flutter/plugins/pull/5914

cyanglaz avatar Jun 30 '22 18:06 cyanglaz

@stuartmorgan @cyanglaz It's ready for your review after implementing optional permissions for multi image picking

PiotrMitkowski avatar Aug 03 '22 15:08 PiotrMitkowski

@cyanglaz I've fixed the code based on your latest remarks. Right now, I can't see an option to request your another review, so I'm pinging through this comment :)

PiotrMitkowski avatar Aug 05 '22 09:08 PiotrMitkowski

auto-submit[bot] avatar Aug 31 '22 13:08 auto-submit[bot]

Thanks for the great work! Is there any schedule for the 0.8.6 version to be published? Really looking forward to it.

idish avatar Sep 13 '22 20:09 idish

It's already available, note it's image_picker_ios https://pub.dev/packages/image_picker_ios/changelog#086

jmagman avatar Sep 13 '22 21:09 jmagman

The PR you'll want to follow to know when you can use this feature as a plugin client is https://github.com/flutter/plugins/pull/5915

stuartmorgan avatar Sep 14 '22 00:09 stuartmorgan

Just tried to implement that in my app and seems as it crashes due to permission issue after picking photos. I think it worth noting that here as well. See my comment: https://github.com/flutter/plugins/pull/5915#issuecomment-1246408949

idish avatar Sep 14 '22 11:09 idish