plugins icon indicating copy to clipboard operation
plugins copied to clipboard

[google_maps_flutter] ios: re-enable test with popup

Open cyanglaz opened this issue 2 years ago • 3 comments

Re-able the test that triggers system alert as it seems not failing anymore in newest iOS versions.

fixes: https://github.com/flutter/flutter/issues/93325

Pre-launch Checklist

  • [ ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ ] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [ ] I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/plugins repo does use dart format.)
  • [ ] I signed the CLA.
  • [ ] The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • [ ] I listed at least one issue that this PR fixes in the description above.
  • [ ] I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • [ ] I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • [ ] I updated/added relevant documentation (doc comments with ///).
  • [ ] I added new tests to check the change I am making, or this PR is test-exempt.
  • [ ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

cyanglaz avatar Apr 20 '22 18:04 cyanglaz

Need to wait until https://github.com/flutter/engine/pull/32820 going to stable before we can land this, so that the test can pass on both stable and master

cyanglaz avatar May 03 '22 16:05 cyanglaz

The engine roll commit is: https://github.com/flutter/flutter/commit/dd65b6ba5bef2a9b62714025429feeb405b046cc

We can merge when is commit is in stable branch.

cyanglaz avatar Jul 12 '22 19:07 cyanglaz

We can merge when is commit is in stable branch.

That day is upon us :)

stuartmorgan avatar Sep 01 '22 20:09 stuartmorgan

This seems to be breaking the tree?

https://ci.chromium.org/ui/p/flutter/builders/prod/Mac_x64%20ios_platform_tests_1_of_4%20stable/17/overview

ditman avatar Dec 01 '22 20:12 ditman