Chris Yang

Results 81 comments of Chris Yang

https://github.com/flutter/engine/pull/33262 was a potential fix for that issue with non-impeller. With impeller, did you have to implement a new RTree to calculate the PlatformView Overlay rect? One of the reasons...

> scrolling in the example app near ToT with --enable impeller reproduces it for me, though it is much more obvious in debug/profile mode than in release mode Just to...

> @cyanglaz Are you still making progress on this? Feel free to un-assign yourself if not. Got distracted by other things, un-assign myself.

cc @hellohuanlin Interesting bit: ``` 3 Flutter 0x102662d54 0x102650000 + 77140 4 camera_avfoundation 0x101ac1f70 __53-[FLTThreadSafeMethodChannel invokeMethod:arguments:]_block_invoke + 60 (FLTThreadSafeMethodChannel.m:24) ```

> `serverClientId` has currently no way to be programmatically configured, but I can implement it if needed. Maybe this deserves another PR? I see, I got confused with these 2...

@Milvintsiss There is a PR trying to add the serverClientId https://github.com/flutter/plugins/pull/5250. It is currently being worked on. Maybe we can cooperate the new changes into this doc change after the...

> Maybe we can add a note about configuring the SERVER_CLIENT_ID in the GoogleService-Info.plist Yes, we should also add a document for adding `SERVER_CLIENT_ID` in `GoogleService-Info.plist`. Would you like to...

@fengyuxx Looks like there are still conflicts. Do you mind merging/rebasing upstream and resolve the conflicts?