Cliff Hansen
Cliff Hansen
In v0.1 when this function was added the documents didn't have the auto-built the API reference pages. Omission was probably to avoid cluttering the solarposition.py module page and only list...
I don't see any downside to adding this function to the API documentation.
@echedey-ls I'm more inclined to remove the inference altogether, rather than continue to check the module parameters and/or the weather. This changed code preserves the old behavior, which is somewhat...
I think we keep the inference, but return 'no_loss' unless parameters for the 'sandia' or 'first_solar' models are found. I would not inspect 'weather' in that inference. If a user...
@echedey-ls I can pick up this PR and move it forward, if you'd like.
> @cwhanse in a previous [comment](https://github.com/pvlib/pvlib-python/pull/2253#issuecomment-2512346462) you said: > > > I think we keep the inference, but return 'no_loss' unless parameters for the 'sandia' or 'first_solar' models are found....
+1 to putting units with the variable names. As far as typesetting, my only complaint about option 3 is that I don't know how to type the superscript characters. I...
What do we think about these directives? https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#describing-changes-between-versions I rather like them but don't want to introduce something that's a pain to manage. If we like them, it would be...
If the deprecation alternative was hyperlinked, where would it appear? It's outside the docstring so not on the readthedocs pages. The message is printed to the terminal window where a...