Cliff Hansen

Results 491 comments of Cliff Hansen

@jesuspolo the pvlib function needs to return something for aoi>90. If you (as primary author of the reference) think that returning 1 is reasonable (I agree with @adriesse here), please...

I'm not quite following. You write "Two functions clearsky.lookup_linke_turbidity and irradiance.get_extra_radiation is tz-naive but has been used as if they were tz-aware" but in the clear-sky user guide, the `times`...

@yhkee0404 aha, I think I partly understand what's going on here. The Linke turbidity data distributed with pvlib are gridded (location), monthly values. These values (from an outside source) do...

Looks good so far @IoannisSifnaios

@adriesse @IoannisSifnaios it's been a while - can you recap where we are with this PR and its reviews?

@IoannisSifnaios I see a number of papers referring lake surface water temperature (LWST) models, or sea surface temperature (SST) models. Most models appear to be dynamic; basically, future temperature is...

It would be great to see a list of parameter name variants you found. In the past, a deprecation process has been followed when a parameter name has changed. I...

@jsstein see @echedey-ls list of parameter names.

> only one ModelChain needs to be instantiated to simulate the PV power generation at all locations This capability (if it proves to give correct results) wasn't intentional and isn't...

@BernatNicolau I would choose one (my preference is also 2004) and name it `muneer2004` or something similar.