Cliff Hansen
Cliff Hansen
> I thought the data processing and fitting would be separate functions, which are then combined in a single workflow later. Me, too. > Do you have an example in...
Another "requirement" for a fitting example here, is that it uses pvanalytics functions in the data preparation. If the data prep is straightforward, and the example fits a model sourced...
Value limits in docstrings: much of that text was ported to python from the original Matlab code. There have been two, sometimes competing objectives for value limits: 1) describe the...
I don't think links to the input definitions add much value. It would be easier to read the list of inputs if the list had one input on each line,...
I mildly prefer the "models in column" format. I think it is more likely to add new models (rows) than to add columns. "Default parameters" > "Generic parameters" for me....
Mild preferences for the third table version over the first. Either are better than the 2nd. The one disadvantage of the third table is that if pvlib adds a few...
@pvlib/pvlib-maintainer does anyone strongly object to the first table format shown here? https://pvlib-python--2353.org.readthedocs.build/en/2353/user_guide/modeling_topics/spectrum.html
I'm in favor of `pvlib/tests/data`, etc. rather than `pvlib/data/tests`.
@echedey-ls can you add "Lookup table" or something like that to the pull down options? For files like the CEC module parameters.
@Chirag3841 you are welcome to. I recommend taking it in several small pull requests.