Cliff Hansen

Results 492 comments of Cliff Hansen

It would be simpler to describe behavior if we could state "tuples are distributed over Arrays". But that's not what happens when the system has only one Array: the tuple...

> Can you provide an example? I'm not seeing that behavior. Neither am I. I must have been imagining what was originally intended by including "tuple of float" in the...

> Tuples should get distributed over Arrays, so tuples of anything (float or Series) should only work when the length of the tuple equals the number of Arrays. We are...

@kandersolar I think I have addressed the review comments

Hmm...I see that I didn't think enough about the tests :) According to the [pandas docs](https://pandas.pydata.org/pandas-docs/stable/user_guide/timeseries.html#ambiguous-times-when-localizing) `infer` requires the timestamps to be monotonic, which they aren't after `normalize`.

This passes tests, but is likely slow due to the looping. I'm now thinking that perhaps `ambiguous=NaT` would be better. The issue arises only when a user wants to use...

> I think even letting the AmbiguousTimeError be raised is fine if the documentation indicates that DST should be handled outside pvlib. That way the user is forced to address...

@scttnlsn can you add yourself to the Contributors list in the whatsnew file? I can do that for you, if needed.

@pvlib/pvanalytics-maintainer if no objections are raised, I will merge this on 9/13

Confirmed the issue with pvlib v0.11.0. The discussion around the pandas issue suggests this occurs when DST adjustment occurs in a way that midnight local never "happens". Short of a...