Cliff Hansen
Cliff Hansen
Since the function is designed to work with spectra (multiple spectrum) as input, I yield, `spectra` can be the variable.
> Is a user guide variable entry necessary It is helpful but not necessary > should existing functions/tests be revised The different input parameter names in `spectrum.calc_spectral_mismatch_field` seem harmless to...
> modify the output of spectrum.spectrl2 to be a dataframe of spectra? I don't think we want to do that. There are multiple arrays in the output of `spectrl2`, for...
Thinking about the API for the agrivoltaics functions, modeling an agrivoltaic system involves a modeling chain that handles both the photovoltaic and crop production. Some steps in that chain are...
Should point to :py:func`pvlib.irradiance.get_ground_diffuse`
@studentayaaljabbari please do!
My opinion: I favor keeping the implementation of references simple. With just text, there's little that can go wrong :) I'm not opposed to a trial using the more automated...
Looking at #2204, as a code reviewer it would be a minor annoyance to have to look in a second file to find a reference's details.
I would be OK with c (status quo, mostly) or a. I would soften "a" a bit by recommending but not insisting on a formatting style. My preference would be...
> restructuring first yes