Liam Miller-Cushon
Liam Miller-Cushon
I'm not sure what "import path" means here? The Java SJD implementation requires direct deps for imports, even if they're unused. I think the Java implementation will report multiple diagnostics...
What meta-info info are you expecting that isn't there? The `_deploy.jar` created by a `java_binary` includes a `Main-Class` entry in the manifest: ``` $ bazel build examples/java-native/src/main/java/com/example/myproject:hello-world_deploy.jar $ unzip -p...
> it's described in the javadoc how to resolve this Do you have a pointer to where in the javadoc it's described, or have any general advice for updating usages...
It seems like the part of http://mydailyjava.blogspot.com/2018/04/jdk-11-and-proxies-in-world-past.html?m=1 about "Supporting proxies on Java versions prior to 9 and past 10" answers my question, is that still a good reference for using...
The CLI has a separate pass that reflows long strings literals (corresponding to `--skip-reflowing-long-strings`): https://github.com/google/google-java-format/blob/5104d0b27888f3bfab7113f5606374cda5632102/core/src/main/java/com/google/googlejavaformat/java/FormatFileCallable.java#L48 The plugin currently just runs the core formatter logic, not the string reflowing part.
> the space is not closed up when google-java-format runs again, even if there is an opportunity to do so This does seem to work for `{@code ... }`, handling...
https://github.com/google/google-java-format/issues/787
``` Caused by: java.lang.IllegalArgumentException: No enum constant javax.lang.model.element.Modifier.SEALED at java.base/java.lang.Enum.valueOf(Enum.java:240) at [email protected]/javax.lang.model.element.Modifier.valueOf(Modifier.java:47) ``` The stack trace indicates that JDK 11 is being used here. `google-java-format` supports `sealed`, but only when...
FWIW our thinking on how this applies to Java code hasn't really changed since @lowasser's comment: we want to do what we can to avoid the need for `// format:off`...
The `//` hack is unnecessary here. The formatter preserves 'tabular' array initializers: ``` $ cat T.java class T { public static final int[] defaultScalingList4x4Inter = { 10, 14, 14, 20,...