Liam Miller-Cushon

Results 378 comments of Liam Miller-Cushon

Please re-open this or file a new bug if you're still seeing issues with Lombok and Error Prone 2.13.0 when `-XepDisableWarningsInGeneratedCode` is enabled.

One thing to try here is using `SuppressibleTreePathScanner` in the implementation of `UnusedVariable`, which should help it skip the lombok generated code.

> How do I add that setting in Maven? See https://errorprone.info/docs/flags#maven You need to pass `-Xplugin:ErrorProne -XepDisableWarningsInGeneratedCode` as a single ``

The analogy to `unchecked` is interesting. One potential disadvantage is that it already has a specific meaning / baggage. I also see parallels with `rawtypes`: aren't legacy nullable types raw...

``` Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make java.lang.String(byte[],byte) accessible: module java.base does not "opens java.lang" to unnamed module @3e07d849 at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354) at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297) at java.base/java.lang.reflect.Constructor.checkCanSetAccessible(Constructor.java:188) at java.base/java.lang.reflect.Constructor.setAccessible(Constructor.java:181) at com.google.devtools.build.lib.unsafe.StringUnsafe.<init>(StringUnsafe.java:75) ```...

I think you want `bazel --host_jvm_args=--add-opens=java.base/java.nio=ALL-UNNAMED build ...`, see https://bazel.build/docs/user-manual#host-jvm-args This needs to be passed to the JVM running Bazel itself, `bazel build --jvmopt=...` is configuring JVM flags for the...

> java.base does not "opens java.lang" That one requires `--add-opens=java.base/java.lang=ALL-UNNAMED`, not `--add-opens=java.base/java.nio=ALL-UNNAMED`, you might need to pass multiple `--add-opens=` flags

Thanks for taking a look! > `new ByteBuddy().with(TypeValidation.DISABLED)` in non-debugging scenarios for performance reason. Without this validation, the invisibility will also be ignored. Thanks, I will look in to doing...

I tried setting `.with(TypeValidation.DISABLED)` everywhere as suggested. I'm no longer getting the `java.lang.IllegalStateException: Invisible parameter type ...` error from bytebuddy, but now I'm getting a `NoSuchMethodException`. So it seems like...