Liam Miller-Cushon
Liam Miller-Cushon
We try to be fairly conservative about adding new annotations to Error Prone. If we don't add this, and you want to get some of the benefits of `ReferenceEquality` with...
> I believe it would be a good candidate for error-prone upstream @carterkozak sorry for the very slow response here, are you still interested in contributing this?
Great, thanks!
``` Caused by: java.lang.NullPointerException: Cannot invoke "java.util.List.iterator()" because the return value of "com.sun.source.tree.CaseTree.getStatements()" is null at org.checkerframework.errorprone.dataflow.cfg.builder.CFGTranslationPhaseOne$SwitchBuilder.buildCase(CFGTranslationPhaseOne.java:2190) at org.checkerframework.errorprone.dataflow.cfg.builder.CFGTranslationPhaseOne$SwitchBuilder.build(CFGTranslationPhaseOne.java:2156) at org.checkerframework.errorprone.dataflow.cfg.builder.CFGTranslationPhaseOne.visitSwitch(CFGTranslationPhaseOne.java:2086) at org.checkerframework.errorprone.dataflow.cfg.builder.CFGTranslationPhaseOne.visitSwitch(CFGTranslationPhaseOne.java:198) ``` This looks like it was fixed...
I think I've seen this a couple of times and hadn't got to the bottom of it yet. To make it easier to debug, maybe we should improve the diagnostic...
I wonder if IntelliJ is adding a unicode character to the buffer for some reason. I'm going to update the diagnostic message to print the character it's seeing, which might...
This should have been included in the recent 2.16.0 release
re: https://github.com/google/error-prone/issues/1250#issuecomment-494385041, if `-Xep:ParameterName:OFF` works around the crash it's a different bug: #780 Re-opening to track crashes related to lombok and `UnusedVariable`.
```java import lombok.extern.flogger.Flogger; @Flogger public class I1250 {} ``` ``` javac -XDcompilePolicy=simple -processorpath lombok-1.18.16.jar:error_prone_core-2.5.1-with-dependencies.jar:dataflow-shaded-3.7.1.jar:jFormatString-3.0.0.jar '-Xplugin:ErrorProne -Xep:UnusedVariable:ERROR -Xep:ReferenceEquality:OFF' -cp lombok-1.18.16.jar:flogger-0.5.1.jar I1250.java ``` ``` import lombok.extern.flogger.Flogger; ^ error-prone version: 2.5.1 BugPattern: UnusedVariable...
@rspilker I think most of the crashes are happening because the source positions for the AST nodes lombok adds are incomplete (e.g. missing end positions), or they get out of...