Michael Crenshaw comments

Results 775 comments of


                                            Michael Crenshaw

chore: upgrade to React 18

@jwinters01 can you pin the argo-ui version in this PR to the upgrade version so we get full CI here?

chore: update leads (max 2 per project)

+1 binding

feat(syncwaves): use binary tree ordering for sync waves

I think folks' main complaint about sync waves is the user experience, not the lack of support for sequential steps within parallel waves. (There's also the request for ordering within...

feat(syncwaves): use binary tree ordering for sync waves

I think I'd find built-in DAG support with dependsOn within a single app context more attractive than a binary tree. It would solve parallelism and UX struggles. But I think...

Community stance on paywalled 'Accelerated bug fixes and security updates via our "soft fork" approach'

Closing since I think Jann explained things nicely. :-)

Source Hydrator not respecting namespace

I think this might be a duplicate of https://github.com/argoproj/argo-cd/issues/24371

Source Hydrator not respecting namespace

Can you update the original issue description output manifest to highlight exactly where you expected cattle-system to be set? One subtlety to keep in mind here is that there is...

Source Hydrator not respecting namespace

What's in your hydrator.metadata for that app? I'm curious what params are being send to `helm template`.

feat(hydrator): syncSource as a different repository (#22719)

Oops! Added. afk now but I'll address your other points ASAP. 🙂

feat(hydrator): syncSource as a different repository (#22719)

@Elyytscha looks like there are some CI failures to sort out. Have time to knock those out?