Michael Crenshaw
Michael Crenshaw
@afzal442 thanks for your contributions and for your interest in becoming an Argoproj member! We'll pick up your request at the next round so you have time to talk to...
@shuangkun what do you think about just moving this s3 code into the argo-workflows repo for easier maintenance? It looks like argo-workflows is the only user of this module. https://github.com/argoproj/argo-cd/issues/22175
The S3 package has been moved to argo-workflows.
Looks like the problem is that `{{.server}}` contains characters that are not allowed in the fields in which it is used. I'd recommend trying `{{.name}}`.
Oh, Helm is picking up the `{{}}` fields and replacing them with empty strings. Try escaping the inner template. ```yaml name: "{{`{{.name}}`}}-infra" ```
Helm chart docs might be okay, but I'm not sure. extraObjects is generic, so adding docs that are specific to AppSets might not make a lot of sense.
If you see a way to rephrase the docs to be clearer, I'd be happy to review a PR! This is one of those things where you kinda just have...
`application.namespaces` should be picked up by by both the server and the controller. Did you restart the components after applying that config? Aside: try to very, very quickly narrow the...
Took a look at generated changes, looks okay to me!
@Marvin9 are you available to review this since you contributed the frontend implementation?