Michael Crenshaw

Results 71 issues of Michael Crenshaw

This PR just exists to run CI checks. Hoping to merge this into the PR branch for https://github.com/argoproj/argo-cd/pull/10026

v1 is [deprecated](https://github.blog/changelog/2022-04-27-code-scanning-deprecation-of-codeql-action-v1/)

# Summary The ApplicationSet CRD inherits validation rules from the Application spec. We should clear out the "required" validation rules for all the `template` fields (i.e. the generator templates and...

enhancement
component:applications-set

# Summary When UserSessionDuration is parsed from `argocd-cm`, failed parsing defaults to 0. Instead, set a reasonable default. https://github.com/argoproj/argo-cd/blob/fdceed6051f2659adff206498a9417695e23e74c/util/settings/settings.go#L1274

enhancement
good first issue
GHC-2022

First timed run of the snyk report was a [raging success](https://github.com/argoproj/argo-cd/runs/7594989282?check_suite_focus=true). ``` ./hack/snyk-report.sh: line 67: snyk: command not found ``` The flag change is in response to this: ``` npm...

# Summary For some reason `ARGOCD_GIT_MODULES_ENABLED` must be set directly on the repo-server Deployment instead of being set in the argocd-cmd-params-cm ConfigMap like most env vars. It should be configurable...

enhancement
good first issue
documentation
GraceHopperOSD2022

I think the table is a bit easier to read.

# Summary Just a TODO list for myself. - [ ] CVE-2022-31129, CVE-2022-2216, CVE-2022-28948 - [x] [Patch](https://github.com/argoproj/argo-cd/pull/10101) - [ ] 2.4 - [x] Cherry-pick - [ ] Release - [...

enhancement
security

Before: snyk output before change ``` $ snyk test --org=argoproj --all-projects --exclude=docs,site --severity-threshold=high --policy-path=.snyk Testing /Users/mcrenshaw/go/src/github.com/argoproj/argo-cd... Organization: argoproj Package manager: gomodules Target file: go.mod Project name: github.com/argoproj/argo-cd/v2 Open source: no...