Michael Crenshaw

I kinda feel like we should bundle and ship the Rollouts extension with Argo CD, unless it's a huge bundle to download.

@andrii-korotkov-verkada can you rebase, now that a number of packages have been removed?

I haven't had time to drive into possible causes yet, but looks like we have enough information to write e2e tests producing at least two failure scenarios. If anyone has...

Thanks! The docs here are reasonably up to date: https://github.com/argoproj/argo-cd/blob/master/test/e2e/hook_test.go And you can probably copy/edit a test here: https://github.com/argoproj/argo-cd/blob/master/test/e2e/hook_test.go

This consistently reproduces the issue: https://github.com/argoproj/argo-cd/pull/23697 The sync weight wasn't necessary, and the additional ConfigMap hook wasn't necessary. We should fix the bug, but also... is `Force=true,Replace=true` actually useful here?...

I don't understand how a PreSync hook with deletion policy `BeforeHookCreation` (the default) could ever encounter an `update` operation. Shouldn't the failed Job always be deleted and then the new...

@PatTheSilent the faulty policy was causing the finalizer to not be removed, or it was causing you to need `Force=true` on the hook resource?

@isarns it looks to me as if the more important bug is that Argo CD isn't deleting the hook resource before creating a new one. What happens if you use...

Gotcha, thanks for clarifying! So setting aside the problematic Kyverno hook, I think we're left with a hook whose finalizer removal is broken by `Replace=true;Force=true`, but it's not clear that...

The S3 package has been moved to argo-workflows.