argo-cd icon indicating copy to clipboard operation
argo-cd copied to clipboard

chore: upgrade to React 18

Open jwinters01 opened this issue 3 months ago • 3 comments

Initial changes for #25203. Upgrades core UI to React 18

NOTE: For this change to work, it also needs to be running the changes from this PR in argo-ui: argoproj/argo-ui#600. This build will fail until that PR gets merged

Checklist:

  • [ ] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • [ ] The title of the PR states what changed and the related issues number (used for the release note).
  • [ ] The title of the PR conforms to the Title of the PR
  • [ ] I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • [ ] I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • [ ] Does this PR require documentation updates?
  • [ ] I've updated documentation as required by this PR.
  • [ ] I have signed off all my commits as required by DCO
  • [ ] I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • [ ] My build is green (troubleshooting builds).
  • [ ] My new feature complies with the feature status guidelines.
  • [ ] I have added a brief description of why this PR is necessary and/or what this PR solves.
  • [ ] Optional. My organization is added to USERS.md.
  • [ ] Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

jwinters01 avatar Nov 18 '25 16:11 jwinters01

🔴 Preview Environment stopped on Bunnyshell

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔵 /bns:start to start the environment
  • :rocket: /bns:deploy to redeploy the environment
  • :x: /bns:delete to remove the environment

bunnyshell[bot] avatar Nov 18 '25 16:11 bunnyshell[bot]

@jwinters01 can you pin the argo-ui version in this PR to the upgrade version so we get full CI here?

crenshaw-dev avatar Nov 18 '25 18:11 crenshaw-dev

@todaywasawesome I believe all my commits are signed off, correct me if I am wrong

jwinters01 avatar Nov 20 '25 19:11 jwinters01