Daniel McCarney comments

Results 647 comments of


                                            Daniel McCarney

Remove notes bugType?

> in my experience it was the slowest part of adding my ML-KEM vectors. Digging deeper at this, was it because you felt like multiple bugTypes were appropriate and it...

Use a more common JSON formatting

Thanks for opening this issue. > I propose we use a uniform encoding, and use one without the extra space. (I.e. we run a tool to rewrite all the old...

Use a more common JSON formatting

Thanks for the offer :-) I think we can get the in-flight PRs merged in the next day or so. If you wanted to open a PR for the JSON...

Use a more common JSON formatting

@davidben things took a little longer than my initial projection (_surely an unprecedented phenomenon for software engineering estimates_ 😅) but I think things are relatively stable now if you're still...

Use a more common JSON formatting

> On the one hand, sorting keys is very easy and something every tool can do. On the other hand, it is a bit sad to not put tcId first,...

Use a more common JSON formatting

@str4d I saw you have [a crate for FPE](https://github.com/str4d/fpe) w/ AES-FF1, but it isn't using the Wycheproof vectors AFAICT. Do you have any thoughts on the encoding discussion with your...

Use a more common JSON formatting

@davidben I took a crack at moving this forward with the simplest approach I could manage. WDYT? https://github.com/C2SP/wycheproof/pull/183

Use Message in Lookup instead of [Record] to preserve section information

> Is there some way better than just all-features to ensure CI will pass before submitting? You can fork the repo, enable actions, and then push a branch name suffixed...

Use Message in Lookup instead of [Record] to preserve section information

Can you update the PR description? I don't think it's in-sync with the branch contents anymore.

Simplification of the Authority trait

I like it too 👍