Daniel McCarney

Results 647 comments of Daniel McCarney

@helgoboss I've backported the invalid SNI tolerance change to the 0.21.x release stream and cut a [0.21.12](https://github.com/rustls/rustls/releases/tag/v%2F0.21.12) you should be able to use. Hope this helps.

> Any more thoughts on if I should fill this out with logic, or do you think this is not realistic to merge this? I'm fairly ambivalent personally but would...

Thanks for confirming this is a quirk of the example registration. > You'll probably find a few other algorithms whose example registration files contain similar quirks. If you do, let...

> pyo3-asyncio has been untouched for two years, and has a hard dependency on a version of pyo3-ffi which is incompatible with the current version 0.25 of pyo3. There's a...

It would be nice to see test coverage for this as well. Maybe a Pebble integration test (https://github.com/djc/instant-acme/blob/main/tests/pebble.rs) that: 1. Spins up a Pebble env, and registers a new account...

> How can I run the pebble test locally? It's a little more tricky than it should be at the moment because we're waiting on an upstream Pebble release. The...

> any update? Updates would be reflected in the comments, & there aren't any since the last round of review. > i can take over if you are unable 👍...

@georgewhewell Since we haven't heard back from the original author in a ~week it seems fair game to me if you want to start a new branch/PR taking over from...

FYI [v0.23.16](https://github.com/rustls/rustls/releases/tag/v%2F0.23.16) was cut today with RPK support.

This feels like a place where `cargo` could be more helpful, allowing expressing something like "defaults minus feature X". In absence of that, and for a crate like hyper-rustls where...