Daniel McCarney

Results 647 comments of Daniel McCarney

@belowm Are you interested in rebasing this branch and addressing [ctz's feedback](https://github.com/rustls/rustls/pull/2382#discussion_r2027424079) ?

> While git history keeps the test code, it is much harder to go through it. Now, even the "Hall of Bugs" in the README contains broken links I've tried...

A meeting occurred between Filippo and Daniel and the direction of the project clarified.

the diff looks good to me too, thanks! If you had time I feel like this could be squashed into a singular commit instead of three.

Is this ready to be flipped out of draft status w/ a rebase & squash or would folks still prefer to see this held until the end-to-end feature works with...

> would you mind approving the workflows to know what's the state of tests at this point? Apologies if this is already something you're aware of, but you can also...

> cpu approved these changes now > cpu self-requested a review now Sorry, hit the review submit button with approved selected when I wanted to just comment.

FWIW I've also run into this with unexpired sessions, and found this previous issue https://github.com/usnistgov/ACVP-Server/issues/183 that seemed to indicate it was a server-side data race 🤷

> What would be the best approach to get these misspellings fixed? If it helps, I can submit a Pull Request. I think a PR fixing these would be welcome....

> transferred this issue from rustls/rustls [now](https://github.com/rustls/pemfile/issues/52#event-13823377656) I think this would be a `rustls/pemfile` discussion. > It has a non-standard extension which contains PEM encodings of further certificates? Huh? I've...