Daniel McCarney

Results 647 comments of Daniel McCarney

> That means there's just one bogo failure left to chase down, TLS-ECH-Client-EarlyData. I will dig into this after some higher priority support work is settled. Fixed; I was using...

> cpu force-pushed the cpu-client-ech branch from 1fa3a32 to de52ea1 * Dropped the aws-lc-rs patch since we're now using [1.7.1](https://github.com/aws/aws-lc-rs/releases/tag/v1.7.1) with the HKDF info maximum limit fix. * Dropped the...

> I'm going to switch my focus to implementing an HPKE provider backed by aws-lc-rs. First pass for this up for review: https://github.com/rustls/rustls/pull/1963 I will rebase this branch on top...

In https://github.com/rustls/rustls/pull/1963 [Ctz asked](https://github.com/rustls/rustls/pull/1963#discussion_r1616140371): > do we want to add a fips() function on ClientConnection/ServerConnection that delegates to the config version, but also takes into account of the crypto backing...

Now that https://github.com/rustls/rustls/pull/1963 is close to merge, how would we like to handle bogo testing w/ `*ring*` as the crypto provider w.r.t the ECH tests? I think there are two...

Initial no-std support was added in [v0.23.0](https://github.com/rustls/rustls/releases/tag/v%2F0.23.0), with some features (`Ticketer`, `ServerSessionMemoryCache`, etc) made unavailable in this configuration. We've since restored those pieces of functionality with https://github.com/rustls/rustls/pull/1688 and I believe...

> Option 2 sounds cleaner to me -- seems okay to have some hacks in the shim. SGTM. > Can we do more of this sort of thing? I think...

> cpu marked this pull request as ready for review now At long last, I think this is ready for review in a non-draft sense. It's been rebased and updated...

> Would it be possible to merge a subset of this PR I think it would probably be easier for you to achieve your goal by taking a Cargo patch...

> Optional: HPKE > > [hpke::Hpke](https://rustdoc.crud.net/jsha/rustls-doc/rustls/crypto/hpke/trait.Hpke.html) > [hpke::HpkeProvider](https://rustdoc.crud.net/jsha/rustls-doc/rustls/crypto/hpke/trait.HpkeProvider.html) Those aren't useful anywhere yet and shouldn't have been included in the docs. Addressed by https://github.com/rustls/rustls/pull/1604