Daniel McCarney

Results 647 comments of Daniel McCarney

> Definitely worth looking at the boringssl test suite -- there are ECH tests there that should be ready to go Oh great! Thanks for the pointer. I will focus...

Now that a bunch of the smaller work has been pulled out and merged I will try to find time to rebase this and address the remaining feedback from djc's...

I needed a break from my current tasks so I rebased this branch and addressed some of the low hanging review feedback. I haven't resolved all of it yet (so...

Hey sayrer, > It all looks good to me. Awesome. Thanks so much for taking a look. I'm focused on this branch again as of the past couple of days...

> cpu force-pushed the cpu-client-ech branch from 9e8d367 to 68cfb74 Pushed some progress from my local branch: * changed the user facing API for configuring ECH to fit into the...

> In particular the client ECH bogo tests are flagging that the inner hello contains some extensions it shouldn't, and most importantly, that I believe I've broken resumption in the...

> that might be a cleaner long-term arrangement. Agreed - my rough plan is to: * ~Figure out the aws-lc-rs provider panic~ * ~Figure out the 5 remaining bogo tests...

> Figure out the aws-lc-rs provider panic I traced this down to a limit that aws-lc-rs was placing on the maximum allowable `info` size for an HKDF expansion. The limit...

> Figure out the ~5 remaining bogo tests I think require adjustment on our side I think I've gotten to the bottom of 4 of the 5 of these ignored...

> I'd suggest waiting before doing a review pass until I've pushed the update. Done. > I think I've gotten to the bottom of 4 of the 5 of these...