Daniel McCarney

Results 647 comments of Daniel McCarney

> Another rough plan to add to those above ... I have a branch with a struct based `CryptoProvider` working end to end. It needs some cleanup but the idea...

Here's a PR implementing the described `CryptoProvider` changes: https://github.com/rustls/rustls/pull/1628

> Client handshake succeeds in TLS 1.3 even though the server has rejected the certificate The crux of the issue here seems to be a difference in behaviour from `connector.connect(...).await`...

> It seems that inconsistent behavior occurs in rustls, which ends the handshaking state before returning peer_has_closed Thanks @quininer - I've moved this issue to the Rustls repo for further...

This makes sense to me, thanks for clarifying! I think it's reasonable to close this.

In the effort of keeping our pull request tracker focused on work in progress I'm going to close this for now. The current consensus on the team is that the...

Needs to be rebased on top of https://github.com/rustls/rustls/pull/1502 - I will look at that once 1502 has been reviewed. I think the main divergences to address are: * The time...

> cpu force-pushed the no-std-support-part-2 branch from c315801 to 1c892b1 * Rebased on top of https://github.com/rustls/rustls/pull/1502 * Applied some minor review fixes (e.g. maintaining discrete commits vs changing the lock...

> cpu marked this pull request as ready for review now ~Now that https://github.com/rustls/rustls/pull/1502 has landed this PR should be ready for review.~ Requires addressing new feedback.

> cpu marked this pull request as draft now Putting this back to draft until I've had a chance to address the feedback RE: the lock trait.