Phillip Cloud
Phillip Cloud
For example, for `rename`, we probably don't need any of the `DerefMap` machinery that's happening in `bind`. `DerefMap` is for cases where there might otherwise be ambiguous parent tables, but...
Same with the `rewrite_project_input` calls, we don't need them.
I'll throw up a PR to remove those and see what breaks.
For `relocate` the problem is a bit trickier, but since it's currently using the full binding machinery as well, we can probably shave a decent constant factor off the top,...
@binste I've put up ~two~ three PRs that should hopefully put this issue to bed for now 😄. ## #9641: `rename` performance Avoids some redundant validation overhead that becomes expensive...
@binste We'll cut 9.2.0 ~today, so you should be able to give this a go shortly 🚀
@binste Nice! So, just to clarify, when you opened this issue you had a **single** expression that took ~30 seconds to compile and now **every** expression out of 56 compiles...
We are going to do a point release soon, and since this is a breaking change it won't go into that release. This will need to go into the next...
Closing this out. As of 9.5 you can pass your own name to the `name` parameter of `value_counts` and `topk`.
FWIW I also released a new version of ibish that should work without pinning any commits (requires ibis-framework 9.0.0)