Phillip Cloud

Results 993 comments of Phillip Cloud

I don't think this is possible to fix. MS SQL doesn't have a boolean type.

Perhaps. Might be worth trying that out in a PR and seeing if it works!

Seems like flink can't handle the new test. Can you mark it as `notyet` or `broken`?

Not really, because it's a repeatable failure. It's almost certainly related to the "large" number of columns (not actually that large). Can you instead xfail the test for now?

@NickCrews > Also, fix a typing bug: map() can accept ArrayValues, not just ArrayColumns. > Also, fix executing Literal(None) on pandas and polars, 0-length arrays on polars > Also, fixing...

> visit_Literal will only need to deal with non-nested values. What do you think, is this worth the churn? I think this is worth exploring for sure. I'm not 100%...

This PR is still too big. Can you split the array, map and struct implementations into three separate PRs?

@NickCrews Just checking in here, can you split these up some more?

We probably need to see the ibis expression. Column names that look like that should effectively never make it into bigquery. Can you give a reproducible example that only uses...