Phillip Cloud
Phillip Cloud
@hoodmane @ryanking13 Any chance one of y'all could help me out here? I am having trouble understanding whether the build timeouts are due to my changes or they are failing...
Ok, I added @carlopi's suggested change. @ryanking13 Will we need to wait on the CI fixes before merging this?
@hoodmane Thanks! I updated the tests with your suggestion. Is the expectation that CI will entirely pass?
No particular reason! Want to PR it?
Ok, so the new compile benchmark simply cannot be run on `main`, because it hits a recursion error. After this PR, the benchmarks look like this: ``` -------------------------------------- benchmark 'test_large_union_compile':...
This may need to be reported upstream to SQLGlot, and hopefully in the meantime there's a SQLGlot compiler flag we can use to set the aliasing style.
How about we just switch to `CREATE VIEW` and not add the complexity of a keyword argument? If people want to drop a table or view first we have a...
Seems like we're potentially misusing `alias` or `alias` has a bug: ``` In [21]: print(sg.alias(expr, 'foo').sql('oracle')) SELECT COUNT(*) AS "CountStar()" FROM (SELECT "t0"."sst_nr" FROM "SOME_TABLE" "t0") "t1" AS foo In...
This would be inside `read_parquet`. Table name generation would remain unchanged when `table_name` is unspecified by the user.
I don't think the `FROM x AS y` failing has anything to do with boolean support. That looks like a separate syntax that was added (in addition to having supported...