ibis icon indicating copy to clipboard operation
ibis copied to clipboard

fix: make topk() use {name}_count format, like .value_counts()

Open NickCrews opened this issue 1 year ago • 2 comments

Fixes (partially) https://github.com/ibis-project/ibis/issues/8540

this is breaking, but I think much better.

NickCrews avatar May 09 '24 02:05 NickCrews

We are going to do a point release soon, and since this is a breaking change it won't go into that release. This will need to go into the next breaking release which will be a while given we have a number of other things to do.

cpcloud avatar May 09 '24 11:05 cpcloud

That sounds fine to me. Just keep this open and merge it in once were ready?

NickCrews avatar May 10 '24 21:05 NickCrews

Closing this out. As of 9.5 you can pass your own name to the name parameter of value_counts and topk.

cpcloud avatar Sep 12 '24 11:09 cpcloud