Phillip Cloud
Phillip Cloud
Ok, I just read through the reports here in more detail and this issue is mixing up two things that are unrelated to each other. There are two issues, one...
xref: https://github.com/ibis-project/ibis/issues/9378
Just saw this! Looks like the log has expired and I can no longer see it. Is this still an issue?
@rtpsw Rebase
I'm going to push some commits to this PR that should address many of the review comments.
I have addressed the feedback, and have added an example implementation of an asof join algorithm using @jvanstraten's suggested generalizations. Hopefully this clarifies how it is to be used!
> This is confusing to me. It looks like two separate approaches mashed together. That's probably because I haven't yet had a chance to update much on the markdown side....
Statefulness aside :) How should we proceed? I still don't know how `tolerance` fits in. A literal seems like it bakes in too many assumptions, and in the more general...
> 5. What does `SORT_DIRECTION_UNSPECIFIED` imply? All of the unspecified suffixes mean that the value wasn't specified when constructing the protobuf. Their only semantic is to communicate that nothing was...
I like `exclude_patterns`. `exclude_invalid_files` implies a notion of validity which will not be uniform across producers and consumers and probably not even consistent across different versions of producers and consumers.