cpathipa
cpathipa
Closing this PR and this is covered in #10375
> AccessKeyTableRows @dwiley-akamai I see what you mean: eliminate `AccessKeyTableRows` and loop through `AccessKeyTableRow` within the `AccessKeyTableBody`, which we could definitely do. I thought we would keep the AccessKeyTableRow logic...
> Only issue I see is this when the Multi-Cluster feature flag is on > >  Now, we return an empty cell instead...
Thank you for the feedback, I will look into that..
> Creating, attaching, and detaching function as expected ✅ > > If you open the Attach drawer but don't select a linode for a few seconds, this error pops up:...
> @cpathipa Any chance you could add some E2E tests for when this feature flag is enabled? @jdamore-linode cypress tests are covered in this PR https://github.com/linode/manager/pull/10626
@jaalah-akamai Good call I will work with DX team to get their approvals on these snippets. Modal open / close is an existing behavior which is working as expected from...
**Update on this PR** : Zhiwei from DX team is going to run all the tools with the generated snippets. Once we get the approval I think we should be...
@jdamore @Jaalah @bnussman @hxu When you get a chance, could you review this PR? We received approval from the DX team for the generated code snippets.
@hkhalil-akamai @mjac0bs Great feedback. @mjac0bs Good call, Actually, the root cause of the issue is having `onSearch` as a dependency in the `useEffect`, which is causing unwanted re-triggers. Removing it...