manager
manager copied to clipboard
refactor: [M3-6903] - Replace Select with Autocomplete in: volumes
Description ๐
This PR eliminates redundant logic and reuses ConfigSelect in AttachVolumeDrawer.
Replaced Select with Autocomplete in ConfigSelect component.
Reused ConfigSelect instead of Select in AttachVolumeDrawer component.
Target release date ๐๏ธ
5/13
How to test ๐งช
Verification steps
(How to verify changes)
- Navigate to http://localhost:3000/volumes and click on attach menu option.
- Verify there is no regression in volume attach / detaching behaviors.
- Verify there is no regression in Volume create flow.
- Navigate to http://localhost:3000/linodes/< Linode_id>/storage - Verify there is no regression in creating / attaching / detaching volumes.
As an Author I have considered ๐ค
Check all that apply
- [ ] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [ ] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 82.29%
Current Coverage: 82.29%
If you open the Attach drawer but don't select a linode for a few seconds, this error pops up:
I'm also observing this. Also, the spacing with the error appears off, there seems to be some extra padding on the left side.
Thank you for the feedback, I will look into that..
Creating, attaching, and detaching function as expected โ
If you open the Attach drawer but don't select a linode for a few seconds, this error pops up:
There's also more space between the fields on this branch compared to prod.
@dwiley-akamai @hana-linode This issue was fixed in the commit b8dbb10
