manager icon indicating copy to clipboard operation
manager copied to clipboard

refactor: [M3-6903] - Replace Select with Autocomplete in: volumes

Open cpathipa opened this issue 1 year ago โ€ข 2 comments

Description ๐Ÿ“

This PR eliminates redundant logic and reuses ConfigSelect in AttachVolumeDrawer. Replaced Select with Autocomplete in ConfigSelect component. Reused ConfigSelect instead of Select in AttachVolumeDrawer component.

Target release date ๐Ÿ—“๏ธ

5/13

How to test ๐Ÿงช

Verification steps

(How to verify changes)

  • Navigate to http://localhost:3000/volumes and click on attach menu option.
  • Verify there is no regression in volume attach / detaching behaviors.
  • Verify there is no regression in Volume create flow.
  • Navigate to http://localhost:3000/linodes/< Linode_id>/storage - Verify there is no regression in creating / attaching / detaching volumes.

As an Author I have considered ๐Ÿค”

Check all that apply

  • [ ] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [ ] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

cpathipa avatar May 03 '24 02:05 cpathipa

Coverage Report: โœ…
Base Coverage: 82.29%
Current Coverage: 82.29%

github-actions[bot] avatar May 03 '24 03:05 github-actions[bot]

If you open the Attach drawer but don't select a linode for a few seconds, this error pops up:

I'm also observing this. Also, the spacing with the error appears off, there seems to be some extra padding on the left side.

hkhalil-akamai avatar May 10 '24 00:05 hkhalil-akamai

Thank you for the feedback, I will look into that..

cpathipa avatar May 28 '24 14:05 cpathipa

Creating, attaching, and detaching function as expected โœ…

If you open the Attach drawer but don't select a linode for a few seconds, this error pops up:

Screenshot 2024-05-08 at 5 03 42โ€ฏPM

There's also more space between the fields on this branch compared to prod.

@dwiley-akamai @hana-linode This issue was fixed in the commit b8dbb10

cpathipa avatar May 29 '24 14:05 cpathipa