manager
manager copied to clipboard
upcoming: [M3-7743] - Handle errors gracefully when FF enabled without MSW
Description ๐
Handles error scenarios gracefully when MSW is off.
Changes ๐
List any change relevant to the reviewer.
- Code cleanup AccessKeyTableRow
- Decoupled AccessKeyTableRow
- Decoupled HostNameTableCell
How to test ๐งช
Prerequisites
(How to setup test environment)
- Turn on OBJ Multi Cluster FF
- Turn OFF MSW
Reproduction steps
(How to reproduce the issue, if applicable)
- Checkout to develop turn on OBJ Multi Cluster FF and MSW OFF.
- Navigate to Accesskey landing page.
- Should notice app crashing.
Verification steps
(How to verify changes)
- Ensure APP is not crashing when FF is turned on in Object storage flow, like Create Bucket, Create / update Access key, Access key landing page etc.
- Turn off the feature flag and ensure there is no regression in object storage flow.
As an Author I have considered ๐ค
Check all that apply
- [ ] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [ ] โ Adding a changeset
- [ ] ๐งช Providing/Improving test coverage
- [ ] ๐ Removing all sensitive information from the code and PR description
- [ ] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 81.33%
Current Coverage: 81.33%
AccessKeyTableRows @dwiley-akamai I see what you mean: eliminate
AccessKeyTableRowsand loop throughAccessKeyTableRowwithin theAccessKeyTableBody, which we could definitely do. I thought we would keep the AccessKeyTableRow logic inAccessKeyTableBody.
cc: @hana-linode for review
Only issue I see is this when the Multi-Cluster feature flag is on
Now, we return an empty cell instead of null when there is no data(MSW off). This addresses the issue.. ( f5c8be6)
