manager icon indicating copy to clipboard operation
manager copied to clipboard

upcoming: [M3-7743] - Handle errors gracefully when FF enabled without MSW

Open cpathipa opened this issue 1 year ago โ€ข 3 comments

Description ๐Ÿ“

Handles error scenarios gracefully when MSW is off.

Changes ๐Ÿ”„

List any change relevant to the reviewer.

  • Code cleanup AccessKeyTableRow
  • Decoupled AccessKeyTableRow
  • Decoupled HostNameTableCell

How to test ๐Ÿงช

Prerequisites

(How to setup test environment)

  • Turn on OBJ Multi Cluster FF
  • Turn OFF MSW

Reproduction steps

(How to reproduce the issue, if applicable)

  • Checkout to develop turn on OBJ Multi Cluster FF and MSW OFF.
  • Navigate to Accesskey landing page.
  • Should notice app crashing.

Verification steps

(How to verify changes)

  • Ensure APP is not crashing when FF is turned on in Object storage flow, like Create Bucket, Create / update Access key, Access key landing page etc.
  • Turn off the feature flag and ensure there is no regression in object storage flow.

As an Author I have considered ๐Ÿค”

Check all that apply

  • [ ] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [ ] โž• Adding a changeset
  • [ ] ๐Ÿงช Providing/Improving test coverage
  • [ ] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [ ] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

cpathipa avatar Feb 13 '24 15:02 cpathipa

Coverage Report: โœ…
Base Coverage: 81.33%
Current Coverage: 81.33%

github-actions[bot] avatar Feb 13 '24 15:02 github-actions[bot]

AccessKeyTableRows @dwiley-akamai I see what you mean: eliminate AccessKeyTableRows and loop through AccessKeyTableRow within the AccessKeyTableBody, which we could definitely do. I thought we would keep the AccessKeyTableRow logic in AccessKeyTableBody.

cpathipa avatar Feb 16 '24 21:02 cpathipa

cc: @hana-linode for review

jaalah-akamai avatar Feb 17 '24 02:02 jaalah-akamai

Only issue I see is this when the Multi-Cluster feature flag is on

Screenshot 2024-02-20 at 10 23 39 AM

Now, we return an empty cell instead of null when there is no data(MSW off). This addresses the issue.. ( f5c8be6)

cpathipa avatar Feb 21 '24 17:02 cpathipa