manager icon indicating copy to clipboard operation
manager copied to clipboard

feat: [M3-8054] - Create Linode - Create Using Command Line (DX Tools Additions)

Open cpathipa opened this issue 1 year ago โ€ข 2 comments

Description ๐Ÿ“

This PR introduces Integrations tab and SDK's tab to ApiAwarenessModal, it generates code snippets for Terraform, Ansible, Go and Python.

Changes ๐Ÿ”„

List any change relevant to the reviewer.

  • Add new tabs to ApiAwarenessModal
  • New utils to generate code snippets
  • Refactored ApiAwarenessModal.

Target release date ๐Ÿ—“๏ธ

7/08

Preview ๐Ÿ“ท

Integrations - Ansible Integrations - Terraform
image image
SDK - GO SDK - Python
image image

How to test ๐Ÿงช

Verification steps

(How to verify changes)

  • Navigate to Linode create flow, click on "View Code Snippets" and turn on feature flag.
  • Verify the new tabs in ApiAwarenessModal.
  • Verify the UX, copy changes, and links.
  • Verify the copy and pate functionality of each code snippet generated.

As an Author I have considered ๐Ÿค”

Check all that apply

  • [x] ๐Ÿ‘€ Doing a self review
  • [ ] โ” Our contribution guidelines
  • [ ] ๐Ÿค Splitting feature into small PRs
  • [x] โž• Adding a changeset
  • [x] ๐Ÿงช Providing/Improving test coverage
  • [x] ๐Ÿ” Removing all sensitive information from the code and PR description
  • [x] ๐Ÿšฉ Using a feature flag to protect the release
  • [ ] ๐Ÿ‘ฃ Providing comprehensive reproduction steps
  • [ ] ๐Ÿ“‘ Providing or updating our documentation
  • [ ] ๐Ÿ•› Scheduling a pair reviewing session
  • [ ] ๐Ÿ“ฑ Providing mobile support
  • [ ] โ™ฟ Providing accessibility support

cpathipa avatar Jun 05 '24 14:06 cpathipa

Coverage Report: โœ…
Base Coverage: 82.37%
Current Coverage: 82.43%

github-actions[bot] avatar Jun 05 '24 15:06 github-actions[bot]

@cpathipa Any chance you could add some E2E tests for when this feature flag is enabled?

jdamore-linode avatar Jun 18 '24 16:06 jdamore-linode

@cpathipa Any chance you could add some E2E tests for when this feature flag is enabled?

@jdamore-linode cypress tests are covered in this PR https://github.com/linode/manager/pull/10626

cpathipa avatar Jul 01 '24 15:07 cpathipa

@cpathipa This is looking good, just a few question:

  • Should we get one of the DX team members to confirm the snippets?
  • I see changes to Create v1 but the modal open/close functionality doesn't seem to be implemented, should it be there?

jaalah-akamai avatar Jul 01 '24 20:07 jaalah-akamai

@jaalah-akamai Good call I will work with DX team to get their approvals on these snippets. Modal open / close is an existing behavior which is working as expected from my end.

https://github.com/linode/manager/assets/119517080/75c3a205-5aab-4631-8135-996fc40348b0

cpathipa avatar Jul 02 '24 00:07 cpathipa

Update on this PR : Zhiwei from DX team is going to run all the tools with the generated snippets. Once we get the approval I think we should be good to move forward on this.

cpathipa avatar Jul 22 '24 19:07 cpathipa

I think this PR is good to go now.

Only issue remains is in the Ansible Collection that authorized_users parameter is not supported by the Ansible Collection, which will be fixed from the DX side.

zliang-akamai avatar Jul 29 '24 18:07 zliang-akamai

@jdamore @Jaalah @bnussman @hxu When you get a chance, could you review this PR? We received approval from the DX team for the generated code snippets.

cpathipa avatar Jul 29 '24 18:07 cpathipa