manager
manager copied to clipboard
feat: [M3-8054] - Create Linode - Create Using Command Line (DX Tools Additions)
Description ๐
This PR introduces Integrations tab and SDK's tab to ApiAwarenessModal, it generates code snippets for Terraform, Ansible, Go and Python.
Changes ๐
List any change relevant to the reviewer.
- Add new tabs to ApiAwarenessModal
- New utils to generate code snippets
- Refactored ApiAwarenessModal.
Target release date ๐๏ธ
7/08
Preview ๐ท
| Integrations - Ansible | Integrations - Terraform |
|---|---|
| SDK - GO | SDK - Python |
|---|---|
How to test ๐งช
Verification steps
(How to verify changes)
- Navigate to Linode create flow, click on "View Code Snippets" and turn on feature flag.
- Verify the new tabs in ApiAwarenessModal.
- Verify the UX, copy changes, and links.
- Verify the copy and pate functionality of each code snippet generated.
As an Author I have considered ๐ค
Check all that apply
- [x] ๐ Doing a self review
- [ ] โ Our contribution guidelines
- [ ] ๐ค Splitting feature into small PRs
- [x] โ Adding a changeset
- [x] ๐งช Providing/Improving test coverage
- [x] ๐ Removing all sensitive information from the code and PR description
- [x] ๐ฉ Using a feature flag to protect the release
- [ ] ๐ฃ Providing comprehensive reproduction steps
- [ ] ๐ Providing or updating our documentation
- [ ] ๐ Scheduling a pair reviewing session
- [ ] ๐ฑ Providing mobile support
- [ ] โฟ Providing accessibility support
Coverage Report: โ
Base Coverage: 82.37%
Current Coverage: 82.43%
@cpathipa Any chance you could add some E2E tests for when this feature flag is enabled?
@cpathipa Any chance you could add some E2E tests for when this feature flag is enabled?
@jdamore-linode cypress tests are covered in this PR https://github.com/linode/manager/pull/10626
@cpathipa This is looking good, just a few question:
- Should we get one of the DX team members to confirm the snippets?
- I see changes to Create v1 but the modal open/close functionality doesn't seem to be implemented, should it be there?
@jaalah-akamai Good call I will work with DX team to get their approvals on these snippets. Modal open / close is an existing behavior which is working as expected from my end.
https://github.com/linode/manager/assets/119517080/75c3a205-5aab-4631-8135-996fc40348b0
Update on this PR : Zhiwei from DX team is going to run all the tools with the generated snippets. Once we get the approval I think we should be good to move forward on this.
I think this PR is good to go now.
Only issue remains is in the Ansible Collection that authorized_users parameter is not supported by the Ansible Collection, which will be fixed from the DX side.
@jdamore @Jaalah @bnussman @hxu When you get a chance, could you review this PR? We received approval from the DX team for the generated code snippets.