Carlos O'Ryan comments

Results 588 comments of


                                            Carlos O'Ryan

Reconsider code coverage approach

I ran an experiment in #3920 to use `llvm-cov`. **Pros** - Seems faster (5m vs. 7m, but that was a single run). - Provides branch coverage, so lines with only...

Customizable Request Client for URL Sourced Credentials

I think this is a dup of #2194 . Do you mind checking and if not, explaining the difference?

Customizable Request Client for URL Sourced Credentials

Ack, thanks.

impl(o11y): add with_tracing to storage client

I am going to close this, feel free to reopen if the work becomes active.

Run a nightly CI with the results from `cargo-audit`

> [ where do you think we should be notified of the results ? I was thinking about this while debugging the related issue and wasn't sure the best way...

Automatically populate the request id in the Compute API

Thanks for the offer! I do not think this is a great task for an external contributor. The code is compute is largely generated, so any changes would need to...

Support enabling the 'aws_lc_rs' (instead of 'rust_cypto') feature on 'jsonwebtoken'

Thanks for the bug report. We will figure out a way to avoid the `rsa` dependency. I also filed #3936 to prevent problems like this in the future.

Storage quickstart sample is flaky

Note that retrying the request may result in `AlreadyExists` errors, we can handle those, but that complicates the sample more than we probably want.

Add support for Workload Identity Federation

> However, it lacks support for Workload Identity Federation, which is Google Cloud's recommended way to access Google Cloud resources from non-Google Cloud environments (Github Actions, AWS, Azure, etc.) without...

impl(gax): gRPC clients can have multiple subchannels

PTAL, I decided to remove some public APIs.