Carlos O'Ryan comments

Results 588 comments of


                                            Carlos O'Ryan

Consider a way to get the operation name from the poller

I just prototyped a solution and it does not require changing any APIs. I am removing this from the stabilization milestone.

Consider a way to get the operation name from the poller

While no breaking changes are needed, I cannot get this to work without larger changes to `*-wkt`. I am going to save the main ideas so we can do this...

showcase: test with all the RPCs for `client::Echo`

Blocked on https://github.com/googleapis/gapic-showcase/issues/1592

showcase: test with all the RPCs for `client::Echo`

The enum problem is not something we can solve, we will ignore that test case.

Fields of `bytes` should be percent-encoded as query parameters

And the proto specification is really `bytes`, not just a string: https://cloud.google.com/iam/docs/reference/rpc/google.iam.admin.v1#google.iam.admin.v1.DeleteRoleRequest

rustls feature for packages using reqwest

Thanks for the bug report. It is obvious by now that we have not been controlling dependencies really well, and TLS dependencies in particular. I believe if we used `rustls`...

rustls feature for packages using reqwest

AFAICT, the next release will not depend on `aws-lc-sys` by default, or `openssl-sys` either. We still need a way to prevent regressions on this.

Prevent unstable dependencies in our public API

We might be able to refactor the definition of all the dependencies to the top-level `Cargo.toml` file. If we did that, then maybe we could run a script to change...

AddressSanitizer: odr-violation on libupb_textformat_lib and libupb_json_lib

@veblush I found a similar problem trying to use bzlmod. They may be completely different bugs, as this is related to CMake.

generator: consider converting repeated fields to HTTP query parameters

Closing for now, does not seem to be needed.