Carlos O'Ryan

Results 490 comments of Carlos O'Ryan

Up to 200 repeats on my workstation, no repro. I may need to move the test to a GCE instance.

I was not able to repro, and it is not repeating. I have asked the GCS team to check their side, but there is nothing actionable at this time. Not...

I really like the idea of supplying multiple custom headers. The variadic template should not be a major issue, the default value for any "option" is "not set" so you...

> > a second constructor for CustomHeader that takes a `std::unordered_map` > > > I really like the idea of supplying multiple custom headers. > > So what do you...

> We should consider adding 2 functions: > > ```c++ > // context is used when `CustomHeader` is present. > void SetCommonOptions(grpc::ClientContext& context, Message& proto, Request& const request); > void...

Punt for now, still sounds like a good idea, but no time right now.

Good thing for the operator to look at

https://pantheon.corp.google.com/cloud-build/builds/07dea1f5-b889-43c0-84e0-0e84f9fd9c9f;step=0?project=cloud-cpp-testing-resources ``` Step #0: INFO[0040] No files changed in this command, skipping snapshotting. Step #0: INFO[0040] RUN /var/tmp/ci/install-cloud-sdk.sh Step #0: INFO[0040] Found cached layer, extracting to filesystem Step #0: error...