Carlos O'Ryan comments

Results 588 comments of


                                            Carlos O'Ryan

docs(auth): id token user guide

@alvarowolfx what did we decide to do with this PR?

Add ptime cmdline arg

/gcbrun

Create an exporter for Cloud Trace

"Stackdriver", I forgot to search for that. Thanks! This is an area where replacing existing things may not help that much, or may actually hurt.

Create an exporter for Cloud Trace

@westarle FYI

Handle pagination for non-standard pagination services

Will these improvements change the client surface in a breaking way? My impression is that they would not, but can you explain why? If they do, then we should add...

Flake in sql admin integration test

Happened again, on my workstation this time: ``` Testing list sql instances SUCCESS on list sql instance: InstancesListResponse { kind: "", warnings: [], items: [], next_page_token: "", _unknown_fields: {} }...

Flake in sql admin integration test

And a third time. This test is getting disabled.

Detect if two variants of a `oneof` field are set in JSON inputs

The fixes for this are going to take multiple steps, which I think deserve at least an outline. 1. I have improved testing to include messages with all the primitive...

Breakdown the fixes for the ProtoJSON conformance test

It may be better to fix #2325, #2324, #2323, #2327 and then run the conformance tests again. Those will clear up many errors.

Implement an OCC loop to update IAM policy bindings

Thanks for the detailed design. Unfortunately we are a bit busy at the moment, and really cannot provide equally detailed feedback. I hope you did not waste too much time...