google-cloud-rust icon indicating copy to clipboard operation
google-cloud-rust copied to clipboard

Handle pagination for non-standard pagination services

Open PhongChuong opened this issue 8 months ago • 3 comments

Some services such as SQL and BigQuery do not follow the pagination standard AIP-4233 such as using max_results instead of page_size and wrapping the field in an additional message layer. As such, paginator is not generated for these List operations. We should look how to handle these special cases.

PhongChuong avatar May 05 '25 15:05 PhongChuong

Code responsible for that is here: https://github.com/googleapis/google-cloud-rust/blob/main/generator/internal/parser/pagination.go

alvarowolfx avatar May 05 '25 17:05 alvarowolfx

Will these improvements change the client surface in a breaking way? My impression is that they would not, but can you explain why? If they do, then we should add this to the stabilization milestone.

coryan avatar May 06 '25 12:05 coryan

I think the improvement change should only amend the service builder with paginator() while keeping everything else untouched so it should not be a breaking change.

PhongChuong avatar May 08 '25 14:05 PhongChuong