nextcloud
on installation save channel to config.php if not stable
- the default channel to the NC server is what is provided in /version.php unless it is overridden in config.php
- the default channel to the NC Updater however is 'stable'
- this resultant in inconsistent results and confusing admin experience
- therefore "stable" is considered default and other channels are being written to config.php now upon installation
This seems to be more straight forward than to maintaining the same strategy of determining a default on the Updater (and forgetting about it).
Fixes https://github.com/nextcloud/updater/issues/436
another alternative would be to make the updater also read the channel from version.php, I believe this information is already read anyway ?
as said in my opening ^:
This [approach] seems to be more straight forward than to maintaining the same strategy of determining a default on the Updater (and forgetting about it).
(did not approve because I do not understand it…)
The updater defaults to the "stable" channel, if none is set otherwise: https://github.com/nextcloud/updater/blob/master/lib/Updater.php#L123-L125 But Nextcloud server, defaults to what is written in version.php.
Now when you install the beta, and a new beta release is available, Nextcloud will notify you about it, but the updater would tell you that there is not update available for beta are only available on beta channel.
I don't know how to make psalm shut up. composer run psalm:update-baseline ends in errors.
I don't know how to make psalm shut up.
composer run psalm:update-baselineends in errors.
composer run psalm:update-baseline is for removing errors from baseline, not adding them.
You need to run composer run psalm -- --set-baseline=tests/psalm-baseline.xml iirc