Corentin Forler

Results 88 comments of Corentin Forler

(I know this issue is old) Here is a minimal example where this error happens (notice the missing `$` in the function signature): ```php

I haven't checked yet, but I believe removing them would fix the bug 👍

I have done an implementation of this feature, with **one access token per app source** (see below). Is this feature still relevant and desired? ![](https://github.com/frappe/press/assets/10946971/99d8aa36-f68a-45ee-9995-be49946fbb53) Should I add a table...

Maybe you could be interested in fixtures? https://discuss.frappe.io/t/custom-app-understanding-fixtures/115794/2. How would your feature request differ from fixtures? Maybe you could create the documents using code in the `after_install` hook?

I believe that your `bench/sites/apps.txt` file is incomplete. It should look like this, at least: ``` frappe erpnext ``` https://github.com/frappe/frappe/blob/f8abd09ab91d0634badc1197626789169839c365/esbuild/utils.js#L70-L77

To download an app you should use `bench get-app eprnext`, which should install it in the bench's Python virtual environment `bench/env`. The problem here is that `erpnext` (as a Python...

> I thought that would install it in the bench's Python virtual environment. ```sh bench/env/bin/activate bench/env/bin/python -m pip install --upgrade -e bench/apps/erpnext ``` You have to activate the virtualenv first,...

@Thatoo The `build` command is provided by the `frappe` app, and is not a built-in in `bench`.

```yaml WARN: Command not being executed in bench directory ``` Does this warning happen when building erpnext?

Would it still be possible to do a stupid override with the following code? (but then this would be actively malicious) ```python class Customer: pass # 😈 class MyCustomerOverride(Customer): def...