Corentin Forler

Results 88 comments of Corentin Forler

> add description? @sumitbhanushali Done! :smiley:

Dropped the other stuff, just kept the fix

Could this make it more difficult to delete documents?

> why is this required? are you facing an issue with the current implementation? @sumitbhanushali Yes, when saving a Report from the Report View (aka Report Builder), the `sort_by` fieldname...

> I am unable to replicate this. Can you tell me which report you are facing issue in? > If it's custom report, how was it prepared? The bug only...

When tabbing out of a Link field, Awesomplete's `tabSelect` behaviour is triggered. While desirable, this behavior might conflict with fast entry: indeed, the list of options shown is obsolete until...

@TremendouslyHighFrequency What you can do: override the frappe.ui.form.ControlLink class by monkey-patching it. ```js $(document).ready(() => { frappe.ui.form.ControlLink = class MyControlLink extends frappe.ui.form.ControlLink { setup_awesomeplete() { super.setup_awesomeplete() this.awesomplete.tabSelect = false }...

Hey :wave: I'm not sure I understand correctly the problem you encountered, to me it looks like the time change is already correctly handled, even the double interpretation of `00:00`...

Hey :wave:, is this PR intended for the website specifically? App and printview already have the `dir` attribute it looks like: https://github.com/frappe/frappe/blob/2f9fd308e85c00d93ef322b805aeaa79faa0acbb/frappe/www/app.html#L2

Would setting `allow_reads_during_maintenance` be a proper alternative (i.e. show a degraded version of the site instead of blocking it completely)?