Corentin Forler

Results 90 comments of Corentin Forler

Remove Contact & Organization store

The Contacts and Users stores don't scale very well indeed: with thousands of contacts the initial app load takes multiple seconds/minutes. https://github.com/frappe/crm/blob/develop/crm/api/session.py It turns out that calling `frappe.get_all` in a...

fix: Fix file/email attachment name containing percent sign

- [x] check if semgrep is right

fix: Fix file/email attachment name containing percent sign

my lovely stalebot, there was activity 😢

fix: Fix file/email attachment name containing percent sign

thanks @akhilnarang

fix: Fix file/email attachment name containing percent sign

All checks are green, PR is ready.

pymysql.err.OperationalError: (1118, 'Row size too large (>8126). Changing some columns to TEXT or BLOB may help.

How many fields do you have in the DocType in total, including custom fields? https://mariadb.com/kb/en/troubleshooting-row-size-too-large-errors-with-innodb/

pymysql.err.OperationalError: (1118, 'Row size too large (>8126). Changing some columns to TEXT or BLOB may help.

[untested] It might be possible to squeeze the fields by changing their Length property: - In the DocType form builder's sidebar: Length is the 4th field - In Customize Form:...

fix(SO): Fix logic to check if supplier has changed

👋

ValidationError: Queue should be one of short, default, long

You need to create a new queue called `build` in `common_site_config.json`. https://discuss.frappe.io/t/frappe-exceptions-validationerror-queue-should-be-one-of-short-default-long-in-frappe-press/124305

Add goal for Activity and/or tags ?

> * Overall Do you mean a Yearly goal? --- > I can't assign a `Label` on this "Issue" I think labels are only available for project maintainers