Corentin Forler

ah semgrep, i bow before you… yes i will change it ``` Mixing functional programming usually yields in confusing code and bugs. Use list comprehensions or generators instead. 189┆ ignore_regex...

This PR is ready, a test case was added.

Full test case: ```python import frappe from erpnext.accounts.doctype.payment_request.payment_request import make_payment_request frappe.set_user("Guest") so_name = frappe.db.get_value("Sales Order", {}) make_payment_request(dt="Sales Order", dn=so_name, submit_doc=True) ``` raises PermissionError @ruthra-kumar

> it tries to submit without first insert The root problem is that the `doc.flags.ignore_permissions` is not set to True anymore in all paths, but it **must be** because the...

Maybe this is related to email encoding (quoted printable)? > an equal sign at the end of a line indicates a soft line break https://stackoverflow.com/questions/15621510/how-to-understand-the-equal-sign-symbol-in-imap-email-text/15621614#15621614

Okay, so the email looks correctly encoded to me… maybe the email client is incorrectly parsing the email for some reason? (cf. [the link mentioned above](https://stackoverflow.com/questions/15621510))

There might be something else inhibiting the pixel tracker, because the value sent is correctly encoded.  https://dencode.com/string/quoted-printable --- What does the following report show? ``https:/YOUR-SITE.COM/app/communication/view/report?communication_date=["Timespan","this+quarter"]&sent_or_received=Sent&_group_by=["`tabCommunication`.`read_by_recipient`",null,"count"]``

Hey @mrPauwHaan, when you navigate using the arrows, the order of the documents is based on the results of the List view. However, when you change a document before going...

not totally compatible with https://github.com/frappe/frappe/pull/26693 out of the box, will have to adjust test_file_with_percent_in_filename before merge

closing this in favor of https://github.com/frappe/frappe/pull/26693